[Webkit-unassigned] [Bug 75812] JSC should be a triple-tier VM

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75812





--- Comment #38 from Gavin Barraclough <barraclough at apple.com>  2012-01-24 18:44:57 PST ---
(From update of attachment 123858)
View in context: https://bugs.webkit.org/attachment.cgi?id=123858&action=review

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:-62
> -#if !defined(NDEBUG) || ENABLE(OPCODE_SAMPLING)

This is enabling dumping in release builds? - I don't think we'll want all these strings in a release binary, this change should be reverted.

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1535
> +#if ENABLE(LLINT)    

I'm saddened to see yet another build flag – though this is clearly necessary until LLInt is ported to all platforms.

Looking toward the future, we may need to think about rationalizing down – typing together LLINT + JIT + DFG + MACRO_ASSEMBLER + YARR_JIT into a single brave-new-world-of-fast-JS-with-JITs switch.

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:1754
> +    if (!interpreter->enabled()) {

This confuses me a little - it looks like if LLInt is being used, interpreter->enabled() will be true, does LLInt not use the structure slots embedded within the instruction stream? – a comment here would probably be useful. :-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.