[Webkit-unassigned] [Bug 75387] Get GDB to display a proper backtrace through JITted functions

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75387


Filip Pizlo <fpizlo at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123762|review?                     |review-
               Flag|                            |




--- Comment #17 from Filip Pizlo <fpizlo at apple.com>  2012-01-24 12:14:34 PST ---
(From update of attachment 123762)
I like this a lot.  Two issues:

1) Fix the build on Qt and Windows.  Seems like Qt doesn't like your use of void*, which should be easy to fix with some static_cast's:


../../../../Source/JavaScriptCore/jit/GDBInterface.cpp:79: error: pointer of type 'void *' used in arithmetic

And Windows is just complaining because the code using gcc/clang specific stuff; probably best to put some #if !OS(WINDOWS) or similar around the relevant code.

2) Would it be possible for you to make the JSCPlugin code use something other than a makefile? For example, that makefile would not work on Mac.  But perhaps autotools would.

Marking r- because of the Qt and Windows build.  Otherwise I think it's probably good to go.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.