[Webkit-unassigned] [Bug 76720] [chromium] Refactor video drawing to be more data driven

Tue Jan 24 11:32:26 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=76720

--- Comment #7 from Adrienne Walker <enne at google.com>  2012-01-24 11:32:26 PST ---
(In reply to comment #6)
> (In reply to comment #5)
> > In the H/W decoded case, there is no upload and the put() call has to be deferred until the draw is issued, IIUC.
> 
> That's right.

Thanks for the clarification! :)

At an abstraction level, I feel like it's LayerRendererChromium's job to only turn quads into GL calls.  I think it's the layer's job to manage resources and generate quads.  That's why pushing all of that code into LayerRendererChromium feels like a layering violation to me.

I think texture upload could still be separated out from drawing if we added a CCLayerImpl::postDraw() function then, instead of a pre-draw one.  The guarantee would be that any layer that had appendQuads called on it would also get a postDraw() call.  Then, CCVideoLayerImpl::appendQuads could upload textures and take a lock, generating quads with not much more than texture ids and rects, while CCVideoLayerImpl::postDraw() would be able to hand back the frame.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.