[Webkit-unassigned] [Bug 73215] [Qt][WK2] Split QWebPermissionRequest into QWebSecurityOrigin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73215





--- Comment #39 from Simon Hausmann <hausmann at webkit.org>  2012-01-24 08:07:49 PST ---
(From update of attachment 123733)
View in context: https://bugs.webkit.org/attachment.cgi?id=123733&action=review

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin.cpp:33
> +bool QtWebSecurityOrigin::containsScheme(const QString& scheme)

I think this function should be called isLocalScheme or something. The current name suggests that it checks if the given scheme is "contained" in the _instance_ of the security origin, which doesn't make much sense to me and it's also not what the function does :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.