[Webkit-unassigned] [Bug 70107] Custom written CSS lexer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=70107


Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123705|review?                     |review+
               Flag|                            |




--- Comment #56 from Antti Koivisto <koivisto at iki.fi>  2012-01-24 06:42:26 PST ---
(From update of attachment 123705)
View in context: https://bugs.webkit.org/attachment.cgi?id=123705&action=review

Looks good to me. It would have been nice to see a performance test that shows the improvement (CSS parser is currently big enough CPU user that it should be very possible to construct a synthetic test that shows the progression). Setting to r+ based on Oliver's comment.

> Source/WebCore/css/CSSParser.cpp:7953
> +        if (hasEscape)
> +            return;
> +
> +        switch (length) {
> +        case 12:
> +            if (isCaselessEqual(name + 2, "ottom-left"))
> +                m_token = BOTTOMLEFT_SYM;
> +            return;
> +
> +        case 13:

I would prefer less empty lines, here and other places.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.