[Webkit-unassigned] [Bug 72952] [GTK] Implement DownloadClient in WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72952





--- Comment #23 from Carlos Garcia Campos <cgarcia at igalia.com>  2012-01-24 00:55:02 PST ---
(In reply to comment #22)
> (From update of attachment 123552 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=123552&action=review
> 
> Looks good. Please make the following fixes before landing. Using WEBKIT_TOP_LEVEL instead of walking up the directory chain is probably the most important thing below.
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp:214
> > +    WebKitDownload* download = webkitDownloadCreate(wkDownload.get());
> > +    downloadsMap().set(wkDownload.get(), download);
> 
> Could you use webkitWebContextGetOrCreateDownload here?

It's a new download, so we don't need to check whether it's in the map.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.