[Webkit-unassigned] [Bug 53644] [GTK] editing/deleting/5408255.html results are incorrect

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53644


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123588|review?, commit-queue?      |review+, commit-queue+
               Flag|                            |




--- Comment #18 from Martin Robinson <mrobinson at webkit.org>  2012-01-23 16:52:12 PST ---
(From update of attachment 123588)
View in context: https://bugs.webkit.org/attachment.cgi?id=123588&action=review

Thanks for fixing this!

>>> Source/WebCore/platform/graphics/gtk/ImageGtk.cpp:74
>>> +    strcat(imageResourcePath, resource);
>> 
>> Doesn't this change the behavior a bit here? Before it would look for $moduleDirectory\share\image.png and now it's looking for $moduleDirectory\share\webkitgtk-3.0\images\image.png? In this case $moduleDirectory is the location of the DLL file.
> 
> Previously, the getWebKitDataDirectory function would just return the data directory, being either $moduleDirectory\share or DATA_DIR. This path would then be used in Image::loadPlatformResource, which would, in the old way, build a filename, starting with the data directory and appending the "webkitgtk-"WEBKITGTK_API_VERSION_STRING, "images" and finally the image name (whatever the OS).
> 
> Now, getPathToImageResource is responsible to deliver the complete path to the required image resource, so on Windows we must further append the required path parts to get the complete and proper path.

Indeed you're right!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.