[Webkit-unassigned] [Bug 75946] The query selector for HTMLContentElement should follow the shadow dom spec.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 23 13:23:10 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=75946


MORITA Hajime <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123524|review?                     |review-
               Flag|                            |




--- Comment #11 from MORITA Hajime <morrita at google.com>  2012-01-23 13:23:10 PST ---
(From update of attachment 123524)
View in context: https://bugs.webkit.org/attachment.cgi?id=123524&action=review

Basically looks OK. Regarding to m_isValidSelector, I feel it as symptom of missing "optional" class like boost::optional. Could you consider to add it to WTF when you have time? Of couse it's a different topic from this bug.

> Source/WebCore/html/shadow/ContentSelectorQuery.cpp:99
> +    default:

Don't use default clause if we have all enums in the case statements. 
Then compilers can catch possible missing case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list