[Webkit-unassigned] [Bug 53733] Timers can fire after a frame has been put into the page cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53733





--- Comment #10 from Brady Eidson <beidson at apple.com>  2012-01-23 13:08:29 PST ---
(In reply to comment #9)
> (In reply to comment #8)
> > Like it or not your patch in 76063 *DOES* do two logically separate things.  It fixes a cross platform WebCore bug and it adds new WebKit2 API.
> > 
> 
> I do not think it does two separate things. 

Yes it does.
1 - It fixes this long standing bug in WebCore, a task tracked here in bug 53733
2 - It adds new WebKit2 API giving the embedding application the ability to forcefully "pause" the web page, a task tracked by 76063

> If this bug did not exist it would not have been an issue. 

If you're saying that if this bug existed then the separate task of adding new WebKit 2 API wouldn't be necessary then we should close 76063 as Invalid and just fix this bug!

>It was pure accident I stumbled across this bug in the code comments. But for bugzilla clarity I wouldn't mind separating the patch. I do like to do at least manual tests, but this has been done, and the code is clear enough. 
> But please note that the last remaining reviewer comments I have against my patch (by Simon Fraser), are on the parts that would be a submitted here instead.

That's fine, and he won't mind.  And I plan on thoroughly reviewing the patch here from scratch.

Thanks!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.