[Webkit-unassigned] [Bug 53644] [GTK] editing/deleting/5408255.html results are incorrect

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53644





--- Comment #16 from Martin Robinson <mrobinson at webkit.org>  2012-01-23 11:45:43 PST ---
(From update of attachment 123588)
View in context: https://bugs.webkit.org/attachment.cgi?id=123588&action=review

Looks nice, but I have a small concern about the Windows stuff.

> Source/WebCore/platform/graphics/gtk/ImageGtk.cpp:74
> +        strcat(dataDirectory, "\\share\\webkitgtk-"WEBKITGTK_API_VERSION_STRING"\\images\\");
>      }
> -    strcat(dataDirectory, "\\share");
>  
> -    return dataDirectory;
> +    char* imageResourcePath = new char[PATH_MAX];
> +    strcat(imageResourcePath, dataDirectory);
> +    strcat(imageResourcePath, resource);

Doesn't this change the behavior a bit here? Before it would look for $moduleDirectory\share\image.png and now it's looking for $moduleDirectory\share\webkitgtk-3.0\images\image.png? In this case $moduleDirectory is the location of the DLL file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.