[Webkit-unassigned] [Bug 76676] Web Inspector: CodeGeneratorInspector.py: add optional runtime validator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76676





--- Comment #7 from Yury Semikhatsky <yurys at chromium.org>  2012-01-23 07:14:31 PST ---
(From update of attachment 123227)
View in context: https://bugs.webkit.org/attachment.cgi?id=123227&action=review

Wrong alignment in generated code:
    if (it != object->end()) {
    Subtype::assertCorrectValue(RefPtr<InspectorValue>(it->second));
        ++count;
    }

> Source/WebCore/inspector/CodeGeneratorInspector.py:180
> +VALIDATOR_IFDEF_NAME = "(!ASSERT_DISABLED)"

should be #if !ASSERT_DISABLED (no parenthesis)

> Source/WebCore/inspector/CodeGeneratorInspector.py:319
> +            return "assertIsString"

assertIsString -> assertString

> Source/WebCore/inspector/CodeGeneratorInspector.py:347
> +            return "assertIsInt"

assertInt

> Source/WebCore/inspector/CodeGeneratorInspector.py:746
> +                                    validator_writer.newline("void %s%s::assertCorrectValue(PassRefPtr<InspectorValue> value)\n" % (helper.full_name_prefix_for_impl, enum_name))

Parameter type should be raw pointer, not PassRefPtr here as you don't pass ownership here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.