[Webkit-unassigned] [Bug 76706] Web Inspector: Make "Copy as HTML" use the same copy functions as other copy methods.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76706





--- Comment #4 from Konrad Piascik <kpiascik at rim.com>  2012-01-23 06:48:44 PST ---
(In reply to comment #2)
> (From update of attachment 123334 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=123334&action=review
> 
> > Source/WebCore/inspector/front-end/ElementsPanel.js:937
> > +        var copy = function(id, text) {
> 
> As I mentioned in the previous review:
> 
> - we only use named functions
> - { should be on the next line
> - this is not "id", this is "error" string
> 
> > Source/WebCore/inspector/front-end/ElementsTreeOutline.js:-1687
> > -        this.representedObject.copyNode();
> 
> It sounds like you could leave implementation of copyNode in DOMAgent given that there are multiple call sites.

Pavel,

2 things: 
1) I want to change the signature of DOMAgent.copyNode() then to not take a callback function since I'll be overwriting it with my own. Objections?

2) Should I be checking for an error inside the callback function copy?  If so what do you think would be the best course of action?  Console.log/error?

I'll put together a new patch with my own thoughts on how to deal with this in the meantime.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.