[Webkit-unassigned] [Bug 76660] [Texmap] Divide TextureMapperNode.cpp to 3 files.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 23 06:03:53 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=76660





--- Comment #11 from Noam Rosenthal <noam.rosenthal at nokia.com>  2012-01-23 06:03:52 PST ---
(In reply to comment #9)
> (From update of attachment 123508 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=123508&action=review
> 
> > Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:-381
> > -    for (size_t i = 0; i < m_animations.size(); ++i) {
> > -        // The same animation name can be used for two animations with different properties.
> > -        if (m_animations[i]->name != keyframesName || m_animations[i]->keyframes.property() != valueList.property())
> > -            continue;
> > -
> > -        // We already have a copy of this animation, that means that we're resuming it rather than adding it.
> > -        RefPtr<TextureMapperAnimation>& animation = m_animations[i];
> > -        animation->animation = Animation::create(anim);
> > -        animation->paused = false;
> > -        animation->startTime = WTF::currentTime() - timeOffset;
> > -        notifyChange(TextureMapperNode::AnimationChange);
> > -        m_animationStartedTimer.startOneShot(0);
> > -        return true;
> > -    }
> 
> I don't see a functional equivalent of this part. Is it intentional?
The functional equivalent part was in GraphicsLayerTextureMapper::addAnimation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list