[Webkit-unassigned] [Bug 76706] Web Inspector: Make "Copy as HTML" use the same copy functions as other copy methods.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76706


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123334|review?                     |review-
               Flag|                            |




--- Comment #2 from Pavel Feldman <pfeldman at chromium.org>  2012-01-23 01:05:43 PST ---
(From update of attachment 123334)
View in context: https://bugs.webkit.org/attachment.cgi?id=123334&action=review

> Source/WebCore/inspector/front-end/ElementsPanel.js:937
> +        var copy = function(id, text) {

As I mentioned in the previous review:

- we only use named functions
- { should be on the next line
- this is not "id", this is "error" string

> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:-1687
> -        this.representedObject.copyNode();

It sounds like you could leave implementation of copyNode in DOMAgent given that there are multiple call sites.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.