[Webkit-unassigned] [Bug 76661] [Qt] [WK2] Support threaded renderer in WK2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76661





--- Comment #16 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-01-22 15:00:37 PST ---
(From update of attachment 123234)
View in context: https://bugs.webkit.org/attachment.cgi?id=123234&action=review

> Source/WebKit2/ChangeLog:10
> +        Added threaded painting support to Qt Webkit2.
> +        All TextureMapper and GraphicsLayer objects are created on rendering
> +        thread and can be accessed through rendering thread only.

Maybe we should make it clear that we are talking about the ui side (which I guess we are without looking at the actual code)

> Source/WebKit2/ChangeLog:18
> +        Layer updates are received through m_messagesToRenderer queue and
> +        applied to QtLayerTreeSceneGraphNode tree in updatePaintNode, when UI thread
> +        is synchronously locked by render thread, so no extra synchronization 
> +        is necessary.
> +        Messages from TextureMapper are delivered back through "callOnMainThread"
> +        interface.
> +        LayerTreeHostProxy is thread safe ref-counted and held alive until paint
> +        node or drawing area destruction.

I would like some newlines to make reading the changelog easier. Or add these details below (in the file listing) like others do

> Source/WebKit2/UIProcess/LayerTreeHostProxy.h:88
> +    typedef void (LayerTreeHostProxy::*MethodPtr)();

Wouldnt it be nicer to have this closer to where it is used?

> Source/WebKit2/UIProcess/LayerTreeHostProxy.h:116
> +    void requestPurgeBackingStores();

sounds weird to me. what about requestBackingStorePurge? or requestGlobalBackingStorePurge? noam?

> Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp:153
> +struct LayerTreeHostProxyMethodRef {

Ref is a bit overloaded.. it is mostly used for the C classes. Maybe we should just call it Reference, or Handle ?

> Source/WebKit2/UIProcess/qt/LayerTreeHostProxyQt.cpp:154
> +    LayerTreeHostProxyMethodRef(LayerTreeHostProxy* layerTreeHostProxy, LayerTreeHostProxy::MethodPtr method) :

coding style. Add the : to the next line

> Source/WebKit2/UIProcess/qt/QtLayerTreeSceneGraphNode.cpp:63
> +// FIXME: temporary until Qt Scenegraph will support custom painting.
> +char const* const* QtLayerTreeSceneGraphNode::ProxyMaterialShader::attributeNames() const

any bug number?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.