[Webkit-unassigned] [Bug 76660] [Texmap] Divide TextureMapperNode.cpp to 3 files.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76660





--- Comment #2 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-01-22 11:40:35 PST ---
(From update of attachment 123219)
View in context: https://bugs.webkit.org/attachment.cgi?id=123219&action=review

Looks fine, but maybe someone else wants to have a look

> Source/WebCore/platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:368
> +    bool listsMatch, hasBigRotation;

two lines please

> Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.cpp:32
> +    if (!duration)
> +        return 0;
> +    const int loopCount = runningTime / duration;

I would normally add newlines after returns like this one

> Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.cpp:80
> +        return solveCubicBezierFunction(ctf->x1(),
> +                                        ctf->y1(),
> +                                        ctf->x2(),
> +                                        ctf->y2(),
> +                                        progress, duration);

why not just keep that one line, is should be no longer than the line above

> Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.cpp:94
> +    // Optimization: special case the edge values (0 and 1).
> +    if (progress == 1.0 || !progress) {

uh I dont like our coding style for this :-)

> Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.h:38
> +    enum PlayState { PlayingState, PausedState, StoppedState };

why not AnimationState?

> Source/WebCore/platform/graphics/texmap/TextureMapperAnimation.h:76
> +    bool hasActiveAnimationsOfType(AnimatedPropertyID type) const;

Would it make sense as a template?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.