[Webkit-unassigned] [Bug 76418] [CMAKE] Split out cross-platform sources

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76418





--- Comment #1 from Patrick R. Gansterer <paroga at paroga.com>  2012-01-21 05:50:09 PST ---
(In reply to comment #0)
> I'd like to suggest a new guideline for the CMake files to encourage consolidation of build systems between ports, specifically to discourage future ports from bringing in more build systems.
> 
> The rule of thumb is as follows:
> 
>   "Source lists, include paths and generators that aren't specific to a single port should be kept somewhere they can be easily reused by new and existing ports."
> 
> In practice, this would mainly affect WebCore/PlatformEfl.cmake but there are bits of PlatformWinCE.cmake that look generally useful as well.
> 
> Where would the portable source lists go? If the feature relates to a third party library backend (Cairo, Pango, ICU, Curl, Soup, GStreamer etc.) I'd suggest Platform.cmake files in line with the existing Platform*.cmake pattern, keeping the core CMakeLists.txt clean.

I agree on this, but I can't say what has to go in which file, since many code parts are mixed up in different files. IMHO to fullfill this requirement we need to "cleanup" some/many of the CPP files first. I also don't know what makes sense to share at the moment. That's the reason why I'd suggest to change the ports to CMake with the current approach and refactor the common parts out of the files when it becomes clearer what can be shared. (This is at least my personal plan)

> As for features like the create_jit_stubs ARM generator in JavaScriptCore/PlatformWinCE.cmake, this should probably have gone in JavaScriptCore/CMakeLists.txt to begin with.

Not sure on this point, since the call is specific for the WinCE ARM assembler and the other ports use inline assembler.

> I think this gentle approach has a better chance of working than previous attempts to replace eg. the GTK+ build system with CMake wholesale.

Are there any interests in switching the GTK+ port to CMake? I already did some inital patches for WinApple (bug 72816) and Wx (bug 73100), but found no time to improve them since then.

> Will roll a patch if there are no objections, but I've been out of the loop for a bit so putting this to the current maintainers.

Every work on this is welcome.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.