[Webkit-unassigned] [Bug 76761] [BlackBerry] Credential backing store implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76761


Rob Buis <rwlbuis at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123421|review?                     |review-
               Flag|                            |




--- Comment #2 from Rob Buis <rwlbuis at gmail.com>  2012-01-20 18:56:59 PST ---
(From update of attachment 123421)
View in context: https://bugs.webkit.org/attachment.cgi?id=123421&action=review

I think it can be improved a bit more, r- for now.

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:66
> +        // create table logins

In  general: Make comments look like sentences by starting with a capital letter and ending with a period.

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:104
> +    // prepare the statments.

statements.

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:105
> +

Why empty line?

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:144
> +    m_updateStatement =0;

= 0

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:254
> +

Why empty line?

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:255
> +    return credential;

Why do we need a temp var here?

> Source/WebCore/platform/network/blackberry/CredentialBackingStore.cpp:288
> +        return false;

This pattern is repeated a lot. Can you come up with macro(s)? If done correctly it will be much shorter and you don't need braces (go into macro).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.