[Webkit-unassigned] [Bug 76131] Text nodes should be merged when deleting a newline (causes wrong line wrapping behavior)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 20 12:37:19 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=76131





--- Comment #4 from Joe Thomas <joethomas at motorola.com>  2012-01-20 12:37:19 PST ---
Created an attachment (id=123362)
 --> (https://bugs.webkit.org/attachment.cgi?id=123362&action=review)
Working Patch

Found out that the issue lies in the asciiLineBreakTable in Source/WebCore/rendering/break_lines.cpp. In asciiLineBreakTable, if there is an opening punctuation {, [,( after a closing punctuation }, ], ), then it is considered that it can be breakable in between. And it is mentioned that this is added to make it compatible with Firefox 3.6 in the comments. 

Attaching a patch which solves the curly bracket issue '}{', which is mentioned in the test case. If the approach is right, I think we should do it for all combinations of {, [, (. 

Checked http://www.unicode.org/reports/tr14/tr14-17.html#ConfProperties, it only says that line break is prohibited before a closing punctuation and after an opening punctuation. Does not talk about whether we can break in between these opening and closing punctuation. Any other documentation that I can refer to ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list