[Webkit-unassigned] [Bug 76713] New: RAII to manage stylesheets for XSLTProcessorLibxslt

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76713

           Summary: RAII to manage stylesheets for XSLTProcessorLibxslt
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: Unspecified
        OS/Version: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: inferno at chromium.org


dydx: inferno-sec, kling: For bug #75978, did you consider defining a NullifyOnReturn RAII object such that it can be used to clear m_stylesheet on destruction?
[09:49am] dydx: inferno-sec, kling: The function XSLTProcessor::transformToString() is reasonably sized (79 lines long) and there seems to be a explicit ordering for using m_stylesheet
[09:49am] inferno-sec: dydx: that XSLTProcessorLibxslt needs to maintain a ref to the stylesheet for callback
[09:51am] dydx: inferno-sec: ok, and ...
[09:51am] kling: dydx: inferno-sec: we could do that. i didn't think this case was exactly screaming for a special solution like that, but your idea is good
[09:52am] dydx: kling: For your consideration, I suggest such a solution since this function seems to have an ordering dependency due to callback nature and it's reasonable long.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.