[Webkit-unassigned] [Bug 73215] [Qt][WK2] Split QWebPermissionRequest into QWebSecurityOrigin

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73215





--- Comment #18 from Simon Hausmann <hausmann at webkit.org>  2012-01-20 07:09:40 PST ---
(From update of attachment 123174)
View in context: https://bugs.webkit.org/attachment.cgi?id=123174&action=review

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin_p.h:57
> +    QtWebSecurityOrigin& operator=(const QtWebSecurityOrigin&);
> +    QtWebSecurityOrigin& operator=(const QUrl&);
> +    bool operator!=(const QtWebSecurityOrigin&);
> +    bool operator==(const QtWebSecurityOrigin&);

I don't think these operators are a good idea for a QObject sub-class. We generally avoid them with polymorphic types. I'd prefer explicit functions to change the state, i.e. a setUrl.

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin_p.h:69
> +    QSharedDataPointer<QtWebSecurityOriginPrivate> d;

A shared data pointer for a QObject that cannot be copied and where the shared data pointer contains a QUrl, which itself has a shared private? I think this can be simplified to a simple QUrl member in here ;-)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.