[Webkit-unassigned] [Bug 73309] [Qt] GC should be parallel on Qt platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73309


Balazs Kelemen <kbalazs at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122934|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #45 from Balazs Kelemen <kbalazs at webkit.org>  2012-01-20 01:21:23 PST ---
(From update of attachment 122934)
View in context: https://bugs.webkit.org/attachment.cgi?id=122934&action=review

I think we need yet another iteration.

> Source/JavaScriptCore/ChangeLog:25
> +        * JavaScriptCore.order:
> +        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
> +        * wtf/MainThread.cpp:
> +        (WTF::initializeMainThread):
> +        (WTF::registerGCThread):
> +        (WTF::isMainThreadOrGCThread):
> +        * wtf/MainThread.h:
> +        * wtf/Platform.h:
> +        * wtf/mac/MainThreadMac.mm:

Please examine what have you changed and why in a few words.

> Source/JavaScriptCore/wtf/MainThread.cpp:-92
> -
>  #if !PLATFORM(MAC)
> -

Again: why??? Zoltan already pointed out in his review that you should not make such changes.

> Source/JavaScriptCore/wtf/MainThread.cpp:-107
> -
>  #else
> -

Ditto.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.