[Webkit-unassigned] [Bug 74386] Migrate createObjectURL & revokeObjectURL to static (Class) methods

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 19 22:43:14 PST 2012


--- Comment #20 from Kaustubh Atrawalkar <kaustubh at motorola.com>  2012-01-19 22:43:13 PST ---
(In reply to comment #19)

Thanks for the review Adam. Please find my comments inline.

> (From update of attachment 123078 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=123078&action=review
> This looks good.  A few minor questions/nits below.  Thanks!
> > Source/WebCore/html/DOMURL.cpp:-28
> > -#if ENABLE(BLOB)
> I'm curious why you moved this ifdef around.  It looks like almost everything is ifdefed anyway.

This is partial implementation of the Meta bug - Implement URL API. Going forward other implementation wont be in #if ENABLE(BLOB) so tried to keep it that way.

> > Source/WebCore/html/DOMURL.cpp:59
> > +    virtual void contextDestroyed()
> Please add the OVERRIDE keyword.  We're just starting to use that in WebKit.

Sure, will add it. 

> > Source/WebCore/html/DOMURL.h:41
> > +class DOMURL : public RefCounted<DOMURL> {
> It looks like DOMURL is now declared outside of ENABLE(BLOB).  Is that what you intend?

Yes, I suppose that's what new URL implementation is expecting. Correct me if I am wrong.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list