[Webkit-unassigned] [Bug 66027] Implementation for "nav-up" "nav-down" "nav-left" "nav-right" properties in CSS3-UI module

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66027





--- Comment #8 from Antonio Gomes <tonikitoo at webkit.org>  2012-01-19 21:58:24 PST ---
(From update of attachment 123237)
View in context: https://bugs.webkit.org/attachment.cgi?id=123237&action=review

patch still does not apply it seems.

anyways, some nitpicks:

> Source/WebCore/page/FocusController.cpp:795
> +    RenderObject* renderer = focusedNode ? focusedNode->renderer() : 0;
> +
> +    if (!renderer)

drop extran line here.

> Source/WebCore/page/FocusController.cpp:833
> +    if (target == "current")
> +        targetFrame = curFrame;
> +    else if (target == "root")
> +        targetFrame = curFrame->tree()->top();

DEFINE_STATIC_LOCAL(AtomicString, Current, ("current"));
DEFINE_STATIC_LOCAL(AtomicString, Root, ("root"))

> Source/WebCore/page/FocusController.cpp:844
> +    if (!anchorNode)
> +        return false;
> +    // if it's same with the current focused, it should be consumed.

add an extra line here.

if -> If

> Source/WebCore/page/FocusController.cpp:852
> +    bool successfullyFocused = setFocusedNode(anchorNode, targetFrame);
> +
> +    if (successfullyFocused)

drop extra line here.

> Source/WebCore/page/FocusController.cpp:854
> +        m_page->chrome()->focusedNodeChanged(anchorNode);
> +    return true;    

add an extra line here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.