[Webkit-unassigned] [Bug 76035] Add state attribute to history's dom interface.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76035





--- Comment #51 from Brady Eidson <beidson at apple.com>  2012-01-19 11:26:43 PST ---
(In reply to comment #50)
> (In reply to comment #49)
> > (From update of attachment 123150 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=123150&action=review
> > 
> > I would r+ now based on the premise that the comment is just obsolete and accidentally left behind.  But we also need to answer Oliver's question.
> > 
> > > LayoutTests/fast/loader/stateobjects/pushstate-state-attribute-only-one-deserialization.html:47
> > > +        shouldBeTrue("event.state === history.state"); // This fails for now, needs to be fixed.
> > 
> > Does this still fail or is this just an obsolete comment?
> 
> Still fails, i'll look at the PopStateEvent issue in a later bug (per comments #14 / #15). Do you want me to get rid of that line?

Oh duh.  We should have a separate bug filed about that specific issue.

Oliver and I have been chatting on IRC and neither of us is convinced one way or the other that DOMObject or SerializedScriptValue is necessarily the right way to go.

We want to talk it over in person to make sure we're on the same page.  Assuming there's no pressing need to get this in RIGHT NOW, let's hold off for now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.