[Webkit-unassigned] [Bug 72589] [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72589


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123143|review?                     |review+
               Flag|                            |




--- Comment #36 from Martin Robinson <mrobinson at webkit.org>  2012-01-19 10:56:02 PST ---
(From update of attachment 123143)
View in context: https://bugs.webkit.org/attachment.cgi?id=123143&action=review

Looks good, but please make the following change before landing.

> Source/WebKit2/UIProcess/WebPageProxy.h:575
> +    String getAccessibilityPlugID() const { return m_accessibilityPlugID; }

In WebKit we typically don't use the getFoo naming scheme. Instead we just use foo().

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.