[Webkit-unassigned] [Bug 76336] [Texmap] TextureMapper creates two many big intermediate surfaces

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76336





--- Comment #14 from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>  2012-01-19 08:37:01 PST ---
(From update of attachment 122644)
View in context: https://bugs.webkit.org/attachment.cgi?id=122644&action=review

LGTM along with some nitpicks.

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:430
> +void TextureMapperNode::paintRecursive(TextureMapperPaintOptions options)

The implicit copy of this TextureMapperPaintOptions isn't necessary anymore if no intemediate surface is used.
Would it be possible to use a const reference and do the additional copy to apply the opacity on the intermediate surface only when you know you'll use it?

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:455
> +    // We have to use combinedForChildren() and not combined(), otherwise layer 3D doesn't work.

layer 3D -> preserves 3D?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.