[Webkit-unassigned] [Bug 76637] Update FloatRect::uniteIfNonZero to use isZero()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76637


Philip Rogers <pdr at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #123133|0                           |1
        is obsolete|                            |
 Attachment #123133|review?, commit-queue?      |
               Flag|                            |
 Attachment #123135|                            |review?, commit-queue?
               Flag|                            |




--- Comment #2 from Philip Rogers <pdr at google.com>  2012-01-19 08:36:07 PST ---
Created an attachment (id=123135)
 --> (https://bugs.webkit.org/attachment.cgi?id=123135&action=review)
Update uniteIfNonZero to use isZero

A note on why I added no tests: I did a little research on what this change will affect and I came up empty handed. I instrumented the code and ran all our tests and visited various popular/complex pages, neither of which registered a difference between the old behavior and the new. The primary use of uniteIfNonZero in regular code is in RenderInline.cpp which, as far as I can tell in my testing, only passes integer values through to this method and should not be affected by this change. I still think this is change will be clearly useful in preventing future bugs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.