[Webkit-unassigned] [Bug 76378] [EFL] Modify the code to webkit-style and adapt to C++ naming.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76378





--- Comment #14 from JungJik Lee <jungjik.lee at samsung.com>  2012-01-19 04:08:01 PST ---
(In reply to comment #13)
> (From update of attachment 123090 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=123090&action=review
> 
> Seems reasonable. r=me provided the change log entry is updated.
> 
> > Source/WebKit/efl/ChangeLog:3
> > +        [EFL] Adapt C++ style and Modify to webkit-style.
> 
> Typo: s/Adapt/Adopt/
> 
it's done.

> > Source/WebKit/efl/ChangeLog:9
> > +        Modify the code to webkit-style and adapt to C++ style naming.
> > +        The logic of the code is not changed.
> 
> You should mention that this patch is about renaming variables to use camelCase and spelling out variable names instead of using abbreviations. In fact, you might want to rename the bug summary accordingly.
> 
Done!

> > Source/WebKit/efl/ewk/ewk_view.cpp:220
> > +#define EWK_VIEW_TYPE_CHECK(ewkView, ...)                                   \
> > +    do {                                                                    \
> 
> We don't normally align \ like this; we place \ after ) followed by exactly one space.
> 
Done!

> > Source/WebKit/efl/ewk/ewk_view.cpp:2961
> > + * @param window_features Features of the new window being created. If it's @c
> > + * 0, it will be created a window with default features.
> 
> I don't understand this comment. Is it saying that if @c is 0, it will create a window with default features?

As far as I know, @c is doxygen keyword to decorate the document. EFL port is documented by doxygen. so it mean if parameter is 0, it will create a window with default feature.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.