[Webkit-unassigned] [Bug 76553] min-width does not work on <table>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76553





--- Comment #4 from Dirk Schulze <krit at webkit.org>  2012-01-18 14:32:25 PST ---
(From update of attachment 122972)
View in context: https://bugs.webkit.org/attachment.cgi?id=122972&action=review

This is not meant as a review, just some code comments.

> Source/WebCore/ChangeLog:7
> +        min-width does not work on <table>
> +        https://bugs.webkit.org/show_bug.cgi?id=76553
> +

Please go a bit more into detail when implementing new features. What did you implement, how did you implement it. For bigger patches a line by line comment next to the changed functions in the ChangeLog might help as well.

> Source/WebCore/rendering/RenderTable.cpp:273
> +    bool isCSSTable = !node() || !node()->hasTagName(tableTag);
> +    if (isCSSTable && (styleWidth.isFixed() && styleWidth.isPositive())) {

At first, no need to add a new boolean, just put it in the if clause. Can this renderer exist without its node? I don't think that this check is necessary. Do other elements than the HTMLTableElement access RenderTable as well? If not, you dan't need this check at all.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.