[Webkit-unassigned] [Bug 76555] window.innerWidth/Height should not include page scale

Wed Jan 18 11:22:59 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=76555

--- Comment #3 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-01-18 11:22:59 PST ---
(From update of attachment 122969)
View in context: https://bugs.webkit.org/attachment.cgi?id=122969&action=review

> Source/WebCore/page/DOMWindow.cpp:1129
> +    return static_cast<int>(view->visibleContentRect(/* includeScrollbars */ true).height() / (m_frame->pageZoomFactor() * m_frame->frameScaleFactor()));

looks correct

> LayoutTests/fast/dom/iframe-inner-size-scaling.html:5
> +<!DOCTYPE html>
> +<html>
> +<head>
> +    <script>
> +        function debug(str) {

I think there is some smarter way for doing script only tests, though I havent done any myself

> LayoutTests/fast/dom/iframe-inner-size-scaling.html:14
> +            // We must use setTimeout since the innerWidth/innerHeight are not yet valid for the iframe.
> +            window.setTimeout(runTests, 0);

Will this trick always work? We really don't want more flaky tests :-)

> LayoutTests/fast/dom/iframe-inner-size-scaling.html:40
> +            debug("SUCCESS!");

log*, but is not debugging

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.