[Webkit-unassigned] [Bug 76265] Cache RenderStyle pointer as a method to avoid performance regression for region styling
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 18 11:22:04 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=76265
Dave Hyatt <hyatt at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122448|review? |review+
Flag| |
--- Comment #3 from Dave Hyatt <hyatt at apple.com> 2012-01-18 11:22:04 PST ---
(From update of attachment 122448)
View in context: https://bugs.webkit.org/attachment.cgi?id=122448&action=review
r=me with minor changes suggested.
> Source/WebCore/rendering/RenderBlock.cpp:247
> + RenderStyle* newStyle = style();
This one isn't buying you anything. Only used once.
> Source/WebCore/rendering/RenderBlock.cpp:2049
> + RenderStyle* cstyle = child->style();
Call this childStyle please, not cstyle.
> Source/WebCore/rendering/RenderBlock.cpp:2146
> + if (cstyle->marginAfterCollapse() == MSEPARATE) {
childStyle not cstyle.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list