[Webkit-unassigned] [Bug 76453] [CSSRegions]Fix region style code in CSSStyleSelector

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76453


Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122916|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #5 from Antti Koivisto <koivisto at iki.fi>  2012-01-18 06:47:38 PST ---
(From update of attachment 122916)
View in context: https://bugs.webkit.org/attachment.cgi?id=122916&action=review

r=me, with a few nits

> Source/WebCore/css/CSSStyleSelector.cpp:674
> +void CSSStyleSelector::collectMatchingRulesForRegion(RuleSet* rules, int& firstRuleIndex, int& lastRuleIndex, bool includeEmptyRules)
> +{
> +    if (m_regionForStyling) {

You should use early return here:

if (!m_regionForStyling)
    return;

> Source/WebCore/css/CSSStyleSelector.cpp:2245
> +inline bool CSSStyleSelector::isInsideRegionRule(CSSMutableStyleDeclaration* styleDeclaration)
> +{

This would be nicer as a static non-member inline. The caller should test if it needs to be called (m_regionForStyling is set).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.