[Webkit-unassigned] [Bug 72589] [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=72589





--- Comment #32 from Mario Sanchez Prada <msanchez at igalia.com>  2012-01-18 03:54:01 PST ---
(In reply to comment #31)
> (From update of attachment 121814 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121814&action=review
> 
> Looks good to me in general, great work!

Thanks again, Carlos. Now it would be great if just one reviewer could perform more formal review of the patch (/me grins) :-)

> > Source/WebKit2/WebProcess/WebPage/gtk/WebPageAccessibilityObjectGtk.cpp:88
> > +    AtkObject* rootObject = accessibilityRootObjectWrapper(atkObject);
> > +    if (!rootObject)
> > +        return 0;
> > +
> > +    return 1;
> 
> This could be simply:
> 
> return accessibilityRootObjectWrapper(atkObject) ? 1 : 0;

Will keep this comment in mind for the next round of "changes", that I'm sure will happen after the patch starts getting formal reviews

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.