[Webkit-unassigned] [Bug 19681] borderColor on table elements should be ignored

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=19681





--- Comment #6 from KishoreGanesh <kbolisetty at innominds.com>  2012-01-18 03:18:05 PST ---
(In reply to comment #5)
> (From update of attachment 121789 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=121789&action=review
> 
> > Source/WebCore/html/HTMLTableElement.cpp:NaN
> >  void HTMLTableElement::parseMappedAttrib
> 
> I think you should be fixing this in HTMLTableElement::additionalAttributeStyleDecls() instead. If there's a border attribute we want to add a border, otherwise we do not. Currently we add a border if either are present. Discarding the bordercolor attribute altogether would be wrong, since the border attribute could be added dynamically later I think.
> 
> > LayoutTests/fast/table/border-table-ignore.html:8
> > +}
> 
> You need a few tests here, each with a a different combination of the 'border' and 'bordercolor' attributes so that the corrected behaviour is clear. FF and Opera only give the table a border if the border attribute is present.

Thanks for the suggestions. I will resubmit the patch with necessary changes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.