[Webkit-unassigned] [Bug 73309] [Qt] GC should be parallel on Qt platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=73309





--- Comment #43 from Balazs Kelemen <kbalazs at webkit.org>  2012-01-18 02:03:46 PST ---
Well, I think the main issue that the changelog don't describe the changes in detail so it's hard to review.

(In reply to comment #42)
> (From update of attachment 122739 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=122739&action=review
> 
> > Source/JavaScriptCore/wtf/MainThread.cpp:-92
> > -
> >  #if !PLATFORM(MAC)
> > -
> 
> Why did you removed these lines?
> 
> > Source/JavaScriptCore/wtf/MainThread.cpp:-107
> > -
> >  #else
> > -
> 
> Ditto.
> 
> > Source/JavaScriptCore/wtf/MainThread.cpp:255
> > +        // This happens if we're running in a process that doesn't care about
> > +        // MainThread.
> 
> Could you write a better explanation here?

This is copy-pasted code, I don't think the comment should be changed.

> 
> Ok, basically I would split this patch into two:
> 
> One which adds the number of processor cores part, and a followup patch which adds the parallel gc feature.

We already have the number of processor cores part, it has been just moved into WTF to be accessible in JSC. Zoltan, do you agree with me that the patch is ok as it is with a better changelog?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.