[Webkit-unassigned] [Bug 75306] ShadowContentElement query should be able to have fallback element.

Wed Jan 18 01:48:07 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=75306

--- Comment #11 from Shinya Kawanaka <shinyak at chromium.org>  2012-01-18 01:48:07 PST ---
(In reply to comment #9)
> (From update of attachment 122718 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=122718&action=review
> 
> Basically looks fine. Could you add some more tests?
> 
> > Source/WebCore/dom/NodeRenderingContext.cpp:85
> > +            if (!shadowContentElement->inclusions()->first()) {
> 
> Could you make this conditional a method on ShadowContentElement? hasInclusion() or something?

Done.

> > LayoutTests/fast/dom/shadow/shadow-contents-fallback.html:1
> > +<!DOCTYPE html>
> 
> Oops, I meant to talk about content inside shadow inside content.
> Such pattern should hit tricky flattening path.

I've added a few more tests about it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.