[Webkit-unassigned] [Bug 76519] Use RenderTheme more in HTMLSelectElement Rather than ifdefs
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 18 01:01:17 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=76519
Jun Mukai <mukai at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #122881|1 |0
is obsolete| |
--- Comment #4 from Jun Mukai <mukai at chromium.org> 2012-01-18 01:01:17 PST ---
(From update of attachment 122881)
View in context: https://bugs.webkit.org/attachment.cgi?id=122881&action=review
>> Source/WebCore/html/HTMLSelectElement.cpp:985
>> + UNUSED_PARAM(event);
>
> UNUSED_PARAM(event) is not needed. Please remove it.
Done
>> Source/WebCore/platform/gtk/RenderThemeGtk.h:85
>> + virtual bool popsMenuByArrowKeys() const { return true; }
>
> Please add 'OVERRIDE' between const and {.
Done
>> Source/WebCore/rendering/RenderTheme.h:184
>> +
>
> RenderTheme::delegatesMenuListRendering() is for <select> too. Please move these declarations beside delegatesMenuListRendering().
Done
>> Source/WebCore/rendering/RenderThemeChromiumLinux.h:77
>> + virtual bool popsMenuBySpaceOrReturn() const { return true; }
>
> Please add 'OVERRIDE' between const and {.
Done
>> Source/WebCore/rendering/RenderThemeMac.h:83
>> + virtual bool popsMenuByArrowKeys() const { return true; }
>
> ditto.
Done
>> Source/WebCore/rendering/RenderThemeSafari.h:88
>> +
>
> You should not modify RenderThemeSafari, which is for Apple Windows port.
Removed back to the original. Thanks for pointing.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list