[Webkit-unassigned] [Bug 67109] [EFL] Queued scroll feature

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67109





--- Comment #15 from Kamil Blank <k.blank at samsung.com>  2012-01-18 00:44:28 PST ---
(In reply to comment #14)
> > Source/WebKit/efl/ewk/ewk_frame.cpp:770
> > +        int visibleWidth, visibleHeight, scrollX, scrollY, scrollDeltaX, scrollDeltaY, frameWidth, frameHeight;
> 
> If possible, put some variable when they are really needed.
> 
> > Source/WebKit/efl/ewk/ewk_frame.cpp:778
> > +        else if (deltaX > frameWidth - scrollX - visibleWidth)
> 
> Reduce repetition of same pattern.
> 
> > Source/WebKit/efl/ewk/ewk_frame.cpp:782
> > +            scrollDeltaX = deltaX;
> 
> This can be an initialization of scrollDeltaX, so else condition won't be required.
> 
> > Source/WebKit/efl/ewk/ewk_frame.cpp:784
> > +        if (scrollY + deltaY < 0)
> 
> Check the webkit coding style, it might be two lines although one of them is comment.
> 
> > Source/WebKit/efl/ewk/ewk_frame.cpp:787
> > +        else if (deltaY > frameHeight - scrollY - visibleHeight)
> 
> Ditto.
> 
> > Source/WebKit/efl/ewk/ewk_frame.cpp:791
> > +            scrollDeltaY = deltaY;
> 
> This can be an initialization of scrollDeltaY, so else condition won't be required.
> 
Thanks I'll fix it.

> > Source/WebKit/efl/ewk/ewk_frame.cpp:799
> > +                smartData->queuedScrolls.idler = ecore_idler_add(_ewk_frame_queued_scrolls_process_cb, smartData);
> 
> I couldn't find ecore_idler_del ? isn't it required ?
Returning ECORE_CALLBACK_CANCEL deletes the idler.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.