[Webkit-unassigned] [Bug 76517] Add [CallWith] support for attributes in JS/V8 idl code generators.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 17 23:53:59 PST 2012


https://bugs.webkit.org/show_bug.cgi?id=76517





--- Comment #5 from Adam Barth <abarth at webkit.org>  2012-01-17 23:53:59 PST ---
(From update of attachment 122877)
View in context: https://bugs.webkit.org/attachment.cgi?id=122877&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2403
> +        push(@$outputArray, "    ScriptExecutionContext* scriptContext = static_cast<JSDOMGlobalObject*>(exec->lexicalGlobalObject())->scriptExecutionContext();\n");
> +        push(@$outputArray, "    if (!scriptContext)\n");
> +        push(@$outputArray, "        return" . ($returnVoid ? "" : " jsUndefined()") . ";\n");

Is this code duplicated from somewhere else in this file?  I was expecting to see some minus lines replaced with a call to this function in the location that currently handles CallWith for methods.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list