[Webkit-unassigned] [Bug 76177] SVG group getBBox returns 0, 0, 0, 0 for a group of perpendicular paths

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76177





--- Comment #13 from Philip Rogers <pdr at google.com>  2012-01-17 18:07:15 PST ---
Thank you for the second review.

(In reply to comment #12)
> (From update of attachment 122806 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=122806&action=review
> 
> Does the test cover the “united with 0,0,0,0” issue?

It does. The test draws two perpendicular lines starting at (5,5) and extending to (5,105) and (105,5). Including (0,0) would have resulted in a bounding box of size 105*105, but starting at the first child results in the expected 100*100 bounding box.

> 
> > Source/WebCore/rendering/svg/SVGRenderSupport.cpp:194
> > +        if (isFirstChild)
> > +            isFirstChild = false;
> 
> No need for the if here. An unconditional assignment does the same thing.

I have a followup patch for the !width() issue and I'll tack on a fix for this unnecessary check.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.