[Webkit-unassigned] [Bug 75306] ShadowContentElement query should be able to have fallback element.

Tue Jan 17 17:43:50 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=75306

MORITA Hajime <morrita at google.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122718|review?                     |review-
               Flag|                            |

--- Comment #9 from MORITA Hajime <morrita at google.com>  2012-01-17 17:43:50 PST ---
(From update of attachment 122718)
View in context: https://bugs.webkit.org/attachment.cgi?id=122718&action=review

Basically looks fine. Could you add some more tests?

> Source/WebCore/dom/NodeRenderingContext.cpp:85
> +            if (!shadowContentElement->inclusions()->first()) {

Could you make this conditional a method on ShadowContentElement? hasInclusion() or something?

> LayoutTests/fast/dom/shadow/shadow-contents-fallback.html:1
> +<!DOCTYPE html>

Oops, I meant to talk about content inside shadow inside content.
Such pattern should hit tricky flattening path.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.