[Webkit-unassigned] [Bug 76187] Add a check-webkit-style exception for GDBInterface.cpp
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 17 16:03:54 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=76187
--- Comment #8 from Martin Robinson <mrobinson at webkit.org> 2012-01-17 16:03:53 PST ---
(From update of attachment 122832)
View in context: https://bugs.webkit.org/attachment.cgi?id=122832&action=review
This looks just fine to me, though there are a couple relaly minor style nits.
> Tools/ChangeLog:4
> + Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
> + that it does not fail the style check.
Typically this is the bug title itself and the description oes below the "Reviewed by" line.
> Tools/Scripts/webkitpy/style/checker.py:230
> + # and __jit_debug_descriptor when integrating with gdb
Missing a period here.
> Tools/Scripts/webkitpy/style/checker_unittest.py:264
> + # Test if the exception for GDBInterface.cpp is in place
Here as well.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list