[Webkit-unassigned] [Bug 76177] SVG group getBBox returns 0, 0, 0, 0 for a group of perpendicular paths
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 17 11:18:15 PST 2012
https://bugs.webkit.org/show_bug.cgi?id=76177
--- Comment #10 from Levi Weintraub <leviw at chromium.org> 2012-01-17 11:18:15 PST ---
(From update of attachment 122548)
View in context: https://bugs.webkit.org/attachment.cgi?id=122548&action=review
LGTM, but need someone else to sign off on it :)
> Source/WebCore/platform/graphics/FloatRect.cpp:114
> + float left = min(x(), other.x());
> + float top = min(y(), other.y());
> + float right = max(maxX(), other.maxX());
> + float bottom = max(maxY(), other.maxY());
As Darin pointed out, we should avoid using these directional names in favor of maxX and maxY to not confuse things in vertical text.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list