[Webkit-unassigned] [Bug 76381] Use precompiled headers in Chromium port on Windows

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76381


Tony Chang <tony at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122645|review?                     |review-
               Flag|                            |




--- Comment #2 from Tony Chang <tony at chromium.org>  2012-01-17 11:09:38 PST ---
(From update of attachment 122645)
View in context: https://bugs.webkit.org/attachment.cgi?id=122645&action=review

Seems fine, just some minor nits.

I'm not sold on the directory Source/gyp/* for these files because chromium currently doesn't use either file in Source/gyp, but maybe that's OK.  Maybe abarth has a better suggestion.

> Source/gyp/WinPrecompile.cpp:35
> + */

The svn:executable bit appears to be set on all these files.

> Source/gyp/WinPrecompile.gypi:37
> +  'conditions': [
> +    ['OS=="win" and chromium_win_pch==1', {
> +        'variables': {
> +            'conditions': [

Nit: This is a mix of 2 space and 4 space indents.  I would use 4 space indents since that's more consistent with the rest of WebKit.

> Source/gyp/WinPrecompile.gypi:41
> +                # We need to calculate the path to the gyp directory
> +                # differently depending on whether we are being built
> +                # stand-alone (via build-webkit --chromium) or as part
> +                # of the Chromium checkout.

80 column line limit doesn't exist in webKit so feel free to unwrap this comment into 2 lines or so.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.