[Webkit-unassigned] [Bug 75652] Inconsistent text selection behavior with option-shift-left/right

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=75652


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #122051|review?                     |review+
               Flag|                            |




--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org>  2012-01-17 11:09:03 PST ---
(From update of attachment 122051)
View in context: https://bugs.webkit.org/attachment.cgi?id=122051&action=review

r=me provided nits below are fixed.

> Source/WebCore/editing/FrameSelection.cpp:946
> +            VisibleSelection newSelection(m_selection);

We prefer newSelection = m_selection over newSelection(m_selection).

> LayoutTests/editing/selection/selection-extend-should-not-move-across-caret-on-mac.html:21
> +    function editingTest(behavior) {
> +        if (window.layoutTestController) {
> +            layoutTestController.dumpAsText();
> +            layoutTestController.setEditingBehavior(behavior);
> +        }

It seems redundant to indent the entire contents inside <script>.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.