[Webkit-unassigned] [Bug 76274] [chromium] Refactor canvas, plugin, and video drawing to be more data-driven

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=76274





--- Comment #14 from Adrienne Walker <enne at google.com>  2012-01-17 10:08:00 PST ---
(From update of attachment 122780)
View in context: https://bugs.webkit.org/attachment.cgi?id=122780&action=review

> Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:193
> +        for (size_t i = 0; i < quadList.size(); ++i) {
> +            CCDrawQuad* drawQuad = quadList[i].get();
> +            EXPECT_EQ(m_blend, drawQuad->needsBlending());
> +        }

Er, this isn't quite right.  appendQuads gets passed a list to append new quads to.  The quads in the list already are from other layers.  This function should probably create new quads and check that needsBlending is correct on them.  You could probably use CCSolidColorDrawQuad as a good stand-in mock quad type to create.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.