[Webkit-unassigned] [Bug 67187] WebAudio DRT support needs an update

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67187





--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2012-01-17 10:01:42 PST ---
(From update of attachment 122732)
View in context: https://bugs.webkit.org/attachment.cgi?id=122732&action=review

Looks nice apart from some style nits. What's necessary to get this working WKTR?

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:535
> +        if (gLayoutTestController->dumpAsAudio()) {
> +            dumpAudio();
> +        } else if (gLayoutTestController->dumpAsText())

No curly braces are ncessary here since the interior block is only one line.

> Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:550
> +        if (!gLayoutTestController->dumpAsAudio()) {

Would an early return above prevent this?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.