[Webkit-unassigned] [Bug 73309] [Qt] GC should be parallel on Qt platform

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 17 05:12:29 PST 2012


--- Comment #40 from Balazs Kelemen <kbalazs at webkit.org>  2012-01-17 05:12:28 PST ---
> > Source/JavaScriptCore/wtf/MainThread.cpp:253
> > +    if (!isGCThread) {
> I would write the comment in 1 line before the if and leave the brackets.

Let me nitting you over! ;) I disagree with this because:
1. it is copy-pasted code
2. scoping the comment makes it easier to read, this is the more common practice in WebKit I think

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list