[Webkit-unassigned] [Bug 76171] [WK2][EFL] creating dummy class derived from ResourceHandleClient for Efl download module.

Tue Jan 17 02:35:40 PST 2012

https://bugs.webkit.org/show_bug.cgi?id=76171

--- Comment #7 from Keunsoon Lee <keunsoon.lee at samsung.com>  2012-01-17 02:35:40 PST ---
(In reply to comment #6)
> (From update of attachment 122719 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=122719&action=review
> 
> > Source/WebKit2/PlatformEfl.cmake:48
> > +    WebProcess/Downloads/efl/DownloadEflImpl.cpp
> 
> I think Impl.cpp postfix is used by chromium port. So, it can make us confuse. In addition, DownloadEflImpl.cpp is not clear file name. In QT port cases, they add QtFileDownload.cpp. I think we also need to use more clear file name.

Thank you for your review.
And thank you for let me know about chromium port's naming rule.

Several people who do not know about WebKit2 Download architecture asked me what EflDownloader is different from DownloadEfl. That is why I changed.

But, I agree with you that the practical class should have port name prefix because it has its own header file.

So, I will change it to EflFileDownloader like QT port, because its purpose is same with QTFileDownloader.

Thank you.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.